Review Board 1.7.19


Bug 875562 - Part 4: Add Support for crash event files to CrashManager

Review Request #24 - Created Jan. 7, 2014 and submitted

Gregory Szorc [:gps]
875562
Reviewers
benjamin@smedbergs.us, dteller@mozilla.com, ted@mielczarek.org
mozilla-central
Bug 875562 - Part 4: Add Support for crash event files to CrashManager

This patch introduces the concepts of the "crash data store" and "crash
event files." The "crash data store" is a data store containing
information about crashes. Data is added to this store directly through
a JavaScript API or by the presence of "crash event files." A "crash
event file" is simply an individual file containing information about
a crash event. These files are periodically scanned and their contents
are merged into the store.

Currently, no specific event files types are defined. This patch merely
begins to implement the infrastructure for dealing with them. Support
for specific crash events will be added in subsequent patches.

 
Content-Type: text/html; charset=utf-8
toolkit/components/crashes/CrashManager.jsm
Revision UNKNOWN New Change
Diff currently unavailable.
Error: The patch to 'toolkit/components/crashes/CrashManager.jsm' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.s1imZg' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.s1imZg/tmpB4zIxs Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.s1imZg/tmpB4zIxs-new.rej
Details
Traceback (most recent call last):
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/views.py", line 117, in view_diff
    request=request)
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 342, in populate_diff_chunks
    chunks = generator.get_chunks()
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 137, in get_chunks
    large_data=True)
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 136, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 141, in _get_chunks_uncached
    old = get_original_file(self.filediff, self.request)
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 143, in get_original_file
    request)
  File "/data/reviewboard-dev/src/reviewboard-dev.allizom.org/lib/python2.6/site-packages/ReviewBoard-1.7.19.dev-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 96, in patch
    (filename, tempdir, patch_output))
Exception: The patch to 'toolkit/components/crashes/CrashManager.jsm' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.s1imZg' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.s1imZg/tmpB4zIxs
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.s1imZg/tmpB4zIxs-new.rej

toolkit/components/crashes/CrashManagerTest.jsm
New File
 
toolkit/components/crashes/Makefile.in
New File
 
toolkit/components/crashes/moz.build
Revision UNKNOWN New Change
 
toolkit/components/crashes/docs/crash-events.rst
New File
 
toolkit/components/crashes/docs/index.rst
New File
 
toolkit/components/crashes/tests/xpcshell/test_crash_manager.js
Revision UNKNOWN New Change
 
toolkit/components/crashes/tests/xpcshell/test_crash_service.js
Revision UNKNOWN New Change
 
toolkit/components/crashes/tests/xpcshell/test_crash_store.js
New File
 
toolkit/components/crashes/tests/xpcshell/xpcshell.ini
Revision UNKNOWN New Change
 
toolkit/components/telemetry/Histograms.json
Revision UNKNOWN New Change
 
  1. toolkit/components/crashes/CrashManager.jsm: Loading...
  2. toolkit/components/crashes/CrashManagerTest.jsm: Loading...
  3. toolkit/components/crashes/Makefile.in: Loading...
  4. toolkit/components/crashes/moz.build: Loading...
  5. toolkit/components/crashes/docs/crash-events.rst: Loading...
  6. toolkit/components/crashes/docs/index.rst: Loading...
  7. toolkit/components/crashes/tests/xpcshell/test_crash_manager.js: Loading...
  8. toolkit/components/crashes/tests/xpcshell/test_crash_service.js: Loading...
  9. toolkit/components/crashes/tests/xpcshell/test_crash_store.js: Loading...
  10. toolkit/components/crashes/tests/xpcshell/xpcshell.ini: Loading...
  11. toolkit/components/telemetry/Histograms.json: Loading...